feat(sqlite): SqliteStateStore has 1 write connection#5744
Merged
poljar merged 2 commits intomatrix-org:mainfrom Oct 3, 2025
Merged
feat(sqlite): SqliteStateStore has 1 write connection#5744poljar merged 2 commits intomatrix-org:mainfrom
SqliteStateStore has 1 write connection#5744poljar merged 2 commits intomatrix-org:mainfrom
Conversation
This patch transforms an inline comment into a doc comment.
This patch introduces a write-only connection in `SqliteStateStore` _à la_ `SqliteEventCacheStore`. The idea is to get many read-only connections, and a single write-only connections behind a lock, so that there is a single writer at a time. This patch renames the `acquire` method to `read`, and it introduces a new `write` connection.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5744 +/- ##
==========================================
- Coverage 88.42% 88.42% -0.01%
==========================================
Files 360 360
Lines 99545 99557 +12
Branches 99545 99557 +12
==========================================
+ Hits 88022 88030 +8
- Misses 7394 7399 +5
+ Partials 4129 4128 -1 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #5744 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces a write-only connection in
SqliteStateStoreà laSqliteEventCacheStore(see #5382 to learn more). The idea is to get many read-only connections, and a single write-only connections behind a lock, so that there is a single writer at a time.This patch renames the
acquiremethod toread, and it introduces a newwriteconnection.database is lockederrors #5362